anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #2695] feat: subagents allow-list (global + per-agent wildcard control) #10413

New Issue
Closed
opened 2026-02-16 18:15:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:15:03 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/2695

State: closed
Merged: No

Summary

Adds configuration-driven allow/deny control over subagent invocation using a global subagents map plus per-agent subagents overrides. Supports wildcard patterns, precedence (longer literal prefix first, later definition wins on ties), and default-deny mode via "*": false.

Key Changes

  • config: Added subagents to global schema and per-agent schema (packages/opencode/src/config/config.ts).
  • logic: New helper packages/opencode/src/agent/subagents.ts providing accessibleSubagents() and isSubagentEnabled() with wildcard + specificity resolution.
  • task tool: Enforces subagent allow list and errors with guidance when a disallowed subagent is requested (packages/opencode/src/tool/task.ts).
  • auto escalation: SessionPrompt.command() now checks allow list before auto-invoking a subagent (packages/opencode/src/session/prompt.ts).
  • tests: Added packages/opencode/test/agent/subagents.test.ts covering default allow, global deny + per-agent allow, wildcard group enable, override, specificity precedence.
  • docs: Updated agents.mdx and config.mdx with usage patterns, resolution rules, and examples.

Behavior

  • If no subagents maps are defined, all subagents remain available (backwards compatible).
  • Adding { "*": false } globally switches to default deny; selectively re-enable with explicit patterns or names.
  • Per-agent map evaluated after global map.
  • Wildcards use simple * → greedy match; specificity = index of first * (longer literal prefix wins), then later definition wins.
  • Disabled subagents do not appear as allowed for Task tool invocation; attempts result in a clear error message pointing to config.

Tests

subagents.test.ts passes (all 5 cases). Existing unrelated failing tests (tool registry initialization ReferenceError and some EditTool replacer cases) are pre-existing and unchanged by this PR.

Typecheck & Build

All packages pass bun turbo typecheck after removing unused variables introduced during development.

Follow-up (Not in Scope Here)

  • Optional: Lightweight advisory on manual @mention of disabled subagent.
  • Optional: Enumerate accessible subagents dynamically in Task tool description.
  • Optional: Fix ToolRegistry cyclic initialization (separate PR).

Migration

No action required. Omit subagents to retain prior behavior.

Risk

Low. Additive config; defaults preserve existing behavior.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/2695 **State:** closed **Merged:** No --- ## Summary Adds configuration-driven allow/deny control over subagent invocation using a global `subagents` map plus per-agent `subagents` overrides. Supports wildcard patterns, precedence (longer literal prefix first, later definition wins on ties), and default-deny mode via `"*": false`. ## Key Changes - config: Added `subagents` to global schema and per-agent schema (`packages/opencode/src/config/config.ts`). - logic: New helper `packages/opencode/src/agent/subagents.ts` providing `accessibleSubagents()` and `isSubagentEnabled()` with wildcard + specificity resolution. - task tool: Enforces subagent allow list and errors with guidance when a disallowed subagent is requested (`packages/opencode/src/tool/task.ts`). - auto escalation: `SessionPrompt.command()` now checks allow list before auto-invoking a subagent (`packages/opencode/src/session/prompt.ts`). - tests: Added `packages/opencode/test/agent/subagents.test.ts` covering default allow, global deny + per-agent allow, wildcard group enable, override, specificity precedence. - docs: Updated `agents.mdx` and `config.mdx` with usage patterns, resolution rules, and examples. ## Behavior - If no `subagents` maps are defined, all subagents remain available (backwards compatible). - Adding `{ "*": false }` globally switches to default deny; selectively re-enable with explicit patterns or names. - Per-agent map evaluated after global map. - Wildcards use simple `*` → greedy match; specificity = index of first `*` (longer literal prefix wins), then later definition wins. - Disabled subagents do not appear as allowed for Task tool invocation; attempts result in a clear error message pointing to config. ## Tests `subagents.test.ts` passes (all 5 cases). Existing unrelated failing tests (tool registry initialization ReferenceError and some EditTool replacer cases) are pre-existing and unchanged by this PR. ## Typecheck & Build All packages pass `bun turbo typecheck` after removing unused variables introduced during development. ## Follow-up (Not in Scope Here) - Optional: Lightweight advisory on manual @mention of disabled subagent. - Optional: Enumerate accessible subagents dynamically in Task tool description. - Optional: Fix ToolRegistry cyclic initialization (separate PR). ## Migration No action required. Omit `subagents` to retain prior behavior. ## Risk Low. Additive config; defaults preserve existing behavior.
yindo added the pull-request label 2026-02-16 18:15:03 -05:00
yindo closed this issue 2026-02-16 18:15:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#10413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?