anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #3344] Feature/enable eslint diagnostics #10605

New Issue
Closed
opened 2026-02-16 18:15:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:15:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/3344

State: closed
Merged: No

Summary

This PR enables ESLint LSP diagnostics alongside TypeScript diagnostics with support for modern ESLint
configuration formats.

Changes Made

1. Removed TypeScript Filter (lsp/client.ts)

  • Removed filter that prevented ESLint diagnostics from showing
  • ESLint diagnostics will now be published alongside TypeScript diagnostics

2. Enhanced ESLint Server (lsp/server.ts)

  • Added findEslintConfig() function that detects multiple config formats
  • Support for modern flat config (eslint.config.ts, etc.)
  • Support for legacy config (.eslintrc.* files)
  • Proper initialization options passed to ESLint LSP server
  • Added logging for debugging ESLint configuration

Testing

  • Make sure you have an ESLint config file (like eslint.config.ts)
  • Restart opencode to pick up changes
  • Open a TypeScript/JavaScript file with ESLint violations
  • You should now see both TypeScript and ESLint diagnostics
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/3344 **State:** closed **Merged:** No --- ## Summary This PR enables ESLint LSP diagnostics alongside TypeScript diagnostics with support for modern ESLint configuration formats. ## Changes Made ### 1. Removed TypeScript Filter (lsp/client.ts) - Removed filter that prevented ESLint diagnostics from showing - ESLint diagnostics will now be published alongside TypeScript diagnostics ### 2. Enhanced ESLint Server (lsp/server.ts) - Added findEslintConfig() function that detects multiple config formats - Support for modern flat config (eslint.config.ts, etc.) - Support for legacy config (.eslintrc.* files) - Proper initialization options passed to ESLint LSP server - Added logging for debugging ESLint configuration ## Testing - Make sure you have an ESLint config file (like eslint.config.ts) - Restart opencode to pick up changes - Open a TypeScript/JavaScript file with ESLint violations - You should now see both TypeScript and ESLint diagnostics
yindo added the pull-request label 2026-02-16 18:15:18 -05:00
yindo closed this issue 2026-02-16 18:15:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#10605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?