anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #4121] fix: Autocomplete with existing space after trigger #10872

New Issue
Closed
opened 2026-02-16 18:15:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:15:37 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/4121

State: closed
Merged: Yes

Fixes #4120.
Fixes #4523.

Changes:

  • The mechanism that closes the autocomplete after the user types a space after the @ trigger is now event-driven, instead of state-driven (to prevent existing text after the @ trigger from hiding the autocomplete)
  • Avoided side-effect inside memo, which is an anti-pattern

This is on my radar to add comprehensive TUI tests for. There are already a few for Autocomplete.
I did test my change thoroughly manually though.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/4121 **State:** closed **Merged:** Yes --- Fixes #4120. Fixes #4523. Changes: - The mechanism that closes the autocomplete after the user types a space after the @ trigger is now event-driven, instead of state-driven (to prevent existing text after the @ trigger from hiding the autocomplete) - Avoided side-effect inside memo, which is an anti-pattern This is on my radar to add comprehensive TUI tests for. There are already a few for Autocomplete. I did test my change thoroughly manually though.
yindo added the pull-request label 2026-02-16 18:15:37 -05:00
yindo closed this issue 2026-02-16 18:15:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#10872
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?