anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #5205] fix: use basename for shell detection to support non-standard paths #11293

New Issue
Closed
opened 2026-02-16 18:16:06 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:16:06 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/5205

State: closed
Merged: Yes

The shell exclusion check for fish and nu was hardcoded to specific paths (/bin/fish, /usr/bin/fish, etc.), which failed for users with shells installed in non-standard locations (e.g., /opt/homebrew/bin/fish, ~/.nix-profile/bin/nu).

Now uses path.basename() to check just the shell name regardless of install path.

Resolves: #5190

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/5205 **State:** closed **Merged:** Yes --- The shell exclusion check for fish and nu was hardcoded to specific paths (/bin/fish, /usr/bin/fish, etc.), which failed for users with shells installed in non-standard locations (e.g., /opt/homebrew/bin/fish, ~/.nix-profile/bin/nu). Now uses path.basename() to check just the shell name regardless of install path. Resolves: #5190
yindo added the pull-request label 2026-02-16 18:16:06 -05:00
yindo closed this issue 2026-02-16 18:16:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#11293
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?