anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #5536] Fix race condition in concurrent session deletion #11460

New Issue
Closed
opened 2026-02-16 18:16:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:16:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/5536

State: closed
Merged: No

Fixes race condition in concurrent session deletion where multiple DELETE requests to /session/{id} return success but don't reliably persist all deletions.

Changes

  • Add write lock to Storage.remove for thread safety
  • Add session-level locking in Session.remove to prevent concurrent deletions

Testing

The fix addresses the root cause identified in issue #5517 by ensuring:

  • Only one deletion process runs per session at a time
  • All storage operations are properly synchronized
  • Concurrent DELETE requests are handled atomically

Closes #5517

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/5536 **State:** closed **Merged:** No --- Fixes race condition in concurrent session deletion where multiple DELETE requests to `/session/{id}` return success but don't reliably persist all deletions. ## Changes - Add write lock to Storage.remove for thread safety - Add session-level locking in Session.remove to prevent concurrent deletions ## Testing The fix addresses the root cause identified in issue #5517 by ensuring: - Only one deletion process runs per session at a time - All storage operations are properly synchronized - Concurrent DELETE requests are handled atomically Closes #5517
yindo added the pull-request label 2026-02-16 18:16:18 -05:00
yindo closed this issue 2026-02-16 18:16:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#11460
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?