anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #5544] fix: input lip visibility for transparent themes #11467

New Issue
Closed
opened 2026-02-16 18:16:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:16:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/5544

State: closed
Merged: Yes

Check backgroundElement.a instead of background.a to determine whether to draw the input box bottom lip. This fixes both:

  • nightowl-transparent theme: lip visible with solid backgroundElement
  • transparent theme: lip invisible with transparent backgroundElement

Previously PR #5524 removed the condition entirely, causing black bars in fully transparent themes. This restores the conditional logic with the correct property check.

The conditional is being restored, although on a different variable theme.backgroundElement, because that also acts as the background of the input box

image

Why we require the conditional rendering ?

image

Above change works well with the nightowl-transparent theme from #5496 and transparent theme from https://github.com/sst/opencode/pull/4572#issuecomment-3567640711

https://github.com/user-attachments/assets/23714909-f629-4a8c-bcad-96e9d08cc3ef

Closes #5496 https://github.com/sst/opencode/pull/4572#issuecomment-3567640711

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/5544 **State:** closed **Merged:** Yes --- Check backgroundElement.a instead of background.a to determine whether to draw the input box bottom lip. This fixes both: - nightowl-transparent theme: lip visible with solid backgroundElement - transparent theme: lip invisible with transparent backgroundElement Previously PR #5524 removed the condition entirely, causing black bars in fully transparent themes. This restores the conditional logic with the correct property check. The conditional is being restored, although on a different variable `theme.backgroundElement`, because that also acts as the background of the input box <img width="1802" height="972" alt="image" src="https://github.com/user-attachments/assets/9bc4739f-fd57-4cc5-a483-e2bdd2df15f0" /> Why we require the conditional rendering ? <img width="1450" height="752" alt="image" src="https://github.com/user-attachments/assets/637ec8df-d6c7-47d8-b82d-3d77fa5761f4" /> Above change works well with the nightowl-transparent theme from #5496 and transparent theme from https://github.com/sst/opencode/pull/4572#issuecomment-3567640711 https://github.com/user-attachments/assets/23714909-f629-4a8c-bcad-96e9d08cc3ef Closes #5496 https://github.com/sst/opencode/pull/4572#issuecomment-3567640711
yindo added the pull-request label 2026-02-16 18:16:18 -05:00
yindo closed this issue 2026-02-16 18:16:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#11467
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?