anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #5875] fix(lsp): use Shell.killTree for proper process cleanup #11624

New Issue
Open
opened 2026-02-16 18:16:30 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:16:30 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/5875

State: open
Merged: No

Summary

  • Use Shell.killTree() in LSP client shutdown for proper process tree cleanup
  • Add spawnLSP() helper that sets detached: true (required for process group kill)

Problem

LSP shutdown was using process.kill() directly which:

  • Only sends SIGTERM without SIGKILL escalation
  • Doesn't kill child processes (e.g., tsserver spawned by typescript-language-server)
  • Doesn't handle Windows process trees

Solution

  • client.ts: Use Shell.killTree() which properly kills process groups and escalates to SIGKILL
  • server.ts: Add spawnLSP() wrapper that spawns with detached: true on Unix (required for -pid group kill)

Related: #3057, #5525

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/5875 **State:** open **Merged:** No --- ## Summary - Use `Shell.killTree()` in LSP client shutdown for proper process tree cleanup - Add `spawnLSP()` helper that sets `detached: true` (required for process group kill) ## Problem LSP shutdown was using `process.kill()` directly which: - Only sends SIGTERM without SIGKILL escalation - Doesn't kill child processes (e.g., `tsserver` spawned by `typescript-language-server`) - Doesn't handle Windows process trees ## Solution - `client.ts`: Use `Shell.killTree()` which properly kills process groups and escalates to SIGKILL - `server.ts`: Add `spawnLSP()` wrapper that spawns with `detached: true` on Unix (required for `-pid` group kill) Related: #3057, #5525
yindo added the pull-request label 2026-02-16 18:16:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#11624
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?