anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #5876] fix(pty): use proper process tree cleanup on disposal #11628

New Issue
Open
opened 2026-02-16 18:16:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:16:31 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/5876

State: open
Merged: No

Summary

  • Add killPtyTree() helper for proper PTY process tree cleanup
  • Use Promise.all() for parallel session cleanup on disposal

Problem

PTY disposal was using process.kill() directly which:

  • Only sends SIGTERM without SIGKILL escalation
  • Doesn't kill child processes spawned by the shell
  • Doesn't handle Windows process trees

Solution

Added killPtyTree() helper (based on Shell.killTree pattern) that:

  • Kills the process group (-pid) on Unix
  • Escalates to SIGKILL after 200ms if needed
  • Uses taskkill /t on Windows for tree kill
  • Properly catches errors for already-exited processes

Related: #3057, #5525

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/5876 **State:** open **Merged:** No --- ## Summary - Add `killPtyTree()` helper for proper PTY process tree cleanup - Use `Promise.all()` for parallel session cleanup on disposal ## Problem PTY disposal was using `process.kill()` directly which: - Only sends SIGTERM without SIGKILL escalation - Doesn't kill child processes spawned by the shell - Doesn't handle Windows process trees ## Solution Added `killPtyTree()` helper (based on `Shell.killTree` pattern) that: - Kills the process group (`-pid`) on Unix - Escalates to SIGKILL after 200ms if needed - Uses `taskkill /t` on Windows for tree kill - Properly catches errors for already-exited processes Related: #3057, #5525
yindo added the pull-request label 2026-02-16 18:16:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#11628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?