anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #5905] feat: add granular external_directory permission configuration #11635

New Issue
Open
opened 2026-02-16 18:16:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:16:32 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/5905

State: open
Merged: No

Closes #5395

Summary

Adds polymorphic configuration for external_directory permission, allowing users to:

  • Split read/write permissions separately
  • Define directory-specific rules with glob patterns
  • Use tilde (~) for home directory paths

Example Configuration

{
  "permission": {
    "external_directory": {
      "read": {
        "directories": {
          "~/projects/docs": "allow",
          "~/.ssh": "deny"
        },
        "default": "ask"
      },
      "write": "deny"
    }
  }
}

Changes

  • Schema: Added polymorphic external_directory config (string OR read/write split OR directory rules)
  • Permission resolver: New ExternalPermission.resolve() utility for path-based permission resolution
  • Tool integration: Added permission checks to read, write, edit, patch, ls, glob, grep
  • Glob patterns: * matches within directory, ** matches across directories
  • Documentation: Updated permissions docs with examples and limitations

Screenshot

opencode-screenshot

The screenshot shows:

  • Reading files from an allowed external directory works
  • Reading from a denied directory shows clear error message
  • Write operations to read-only directories are blocked

Known Limitations

  • bash tool uses best-effort detection (documented)
  • Symlink escape vulnerability tracked as follow-up
  • LSP tools bypass tracked as follow-up

Testing

  • 28 new tests for ExternalPermission.resolve()
  • All 345 tests pass
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/5905 **State:** open **Merged:** No --- Closes #5395 ## Summary Adds polymorphic configuration for `external_directory` permission, allowing users to: - Split read/write permissions separately - Define directory-specific rules with glob patterns - Use tilde (`~`) for home directory paths ## Example Configuration ```json { "permission": { "external_directory": { "read": { "directories": { "~/projects/docs": "allow", "~/.ssh": "deny" }, "default": "ask" }, "write": "deny" } } } ``` ## Changes - **Schema**: Added polymorphic `external_directory` config (string OR read/write split OR directory rules) - **Permission resolver**: New `ExternalPermission.resolve()` utility for path-based permission resolution - **Tool integration**: Added permission checks to `read`, `write`, `edit`, `patch`, `ls`, `glob`, `grep` - **Glob patterns**: `*` matches within directory, `**` matches across directories - **Documentation**: Updated permissions docs with examples and limitations ## Screenshot <img width="1585" height="1404" alt="opencode-screenshot" src="https://github.com/user-attachments/assets/1a9c5bfe-4127-45dc-bb46-6a876e71a321" /> The screenshot shows: - Reading files from an allowed external directory works - Reading from a denied directory shows clear error message - Write operations to read-only directories are blocked ## Known Limitations - `bash` tool uses best-effort detection (documented) - Symlink escape vulnerability tracked as follow-up - LSP tools bypass tracked as follow-up ## Testing - 28 new tests for `ExternalPermission.resolve()` - All 345 tests pass
yindo added the pull-request label 2026-02-16 18:16:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#11635
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?