anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #6359] fix: prevent model list corruption from SolidJS reactivity #11855

New Issue
Closed
opened 2026-02-16 18:16:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:16:47 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/6359

State: closed
Merged: Yes

Model store gets fed react proxy objects, so the cache is corrupted on some model changes.

  • Deep copy objects when inserting into recent/favorite stores to break reactive proxy references
  • Only filter models from provider sections if actually displayed in Recent section

To repeat the existing problem (and show that the new behavior is correct), try this without exiting opencode in between.

  • Enter opencode
  • /models # and change to a model not on recent list
  • /models. # and change back to the previous model again
  • /models. # will show that is has lost your first model change.
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/6359 **State:** closed **Merged:** Yes --- Model store gets fed react proxy objects, so the cache is corrupted on some model changes. - Deep copy objects when inserting into recent/favorite stores to break reactive proxy references - Only filter models from provider sections if actually displayed in Recent section To repeat the existing problem (and show that the new behavior is correct), try this without exiting opencode in between. * Enter opencode * /models # and change to a model not on recent list * /models. # and change back to the previous model again * /models. # will show that is has lost your first model change.
yindo added the pull-request label 2026-02-16 18:16:47 -05:00
yindo closed this issue 2026-02-16 18:16:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#11855
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?