anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #6421] perf(skill): optimize permission checks with O(1) lookup #11894

New Issue
Open
opened 2026-02-16 18:16:50 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:16:50 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/6421

State: open
Merged: No

Summary

Optimizes SkillTool permission checking by using a Map for O(1) lookups instead of re-running Wildcard.all() in execute.

Changes

  • Single-pass initialization using reduce to build both accessibleSkills (for description) and permissionMap (for execute)
  • O(1) permission lookup in execute instead of O(n) wildcard matching
  • Reuse accessibleSkills for error messages instead of calling Skill.all() again
  • Only call Agent.get() in the denied path (error case)

Notes

  • When no agent is provided, permissionMap is null and all skills are allowed
  • All existing tests pass
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/6421 **State:** open **Merged:** No --- ## Summary Optimizes SkillTool permission checking by using a Map for O(1) lookups instead of re-running Wildcard.all() in execute. ## Changes - Single-pass initialization using `reduce` to build both `accessibleSkills` (for description) and `permissionMap` (for execute) - O(1) permission lookup in execute instead of O(n) wildcard matching - Reuse `accessibleSkills` for error messages instead of calling `Skill.all()` again - Only call `Agent.get()` in the denied path (error case) ## Notes - When no agent is provided, `permissionMap` is null and all skills are allowed - All existing tests pass
yindo added the pull-request label 2026-02-16 18:16:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#11894
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?