anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #6737] fix: handle redirected_statement treesitter node in bash permissions #12074

New Issue
Closed
opened 2026-02-16 18:17:00 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:00 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/6737

State: closed
Merged: Yes

Fixes #5330

This patch fixes two issues in bash tool permission handling:

1. bash redirect statements are not handled (treesitter-bash usage)

Any commands parsed don't have redirects included (e.g. ls foo > bar results in ls foo) which prevents permission rules to match properly (e.g. "ls *>*": "deny" does not apply).

Cause: Redirect statements are parents of commands, thus not recognized in the loop over descendantsOfType("command")

$ echo "ls hello > /dev/null" | tree-sitter parse

(program [0, 0] - [1, 0]
  (redirected_statement [0, 0] - [0, 20]
    body: (command [0, 0] - [0, 8]
      name: (command_name [0, 0] - [0, 2]
        (word [0, 0] - [0, 2]))
      argument: (word [0, 3] - [0, 8]))
    redirect: (file_redirect [0, 9] - [0, 20]
      destination: (word [0, 11] - [0, 20]))))

Solution: use node.parent.text for the pattern matching, which includes the full command

2. bash always pattern lacks a space after the command

Approving ls adds ls* as an always pattern, which allows also other commands (e.g. lsof) which is not intended.

Solution: add a space so ls* becomes ls * in the pattern

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/6737 **State:** closed **Merged:** Yes --- Fixes #5330 This patch fixes two issues in bash tool permission handling: **1. bash redirect statements are not handled (treesitter-bash usage)** Any commands parsed don't have redirects included (e.g. `ls foo > bar` results in `ls foo`) which prevents permission rules to match properly (e.g. `"ls *>*": "deny"` does not apply). Cause: Redirect statements are parents of commands, thus not recognized in the loop over `descendantsOfType("command")` ```bash $ echo "ls hello > /dev/null" | tree-sitter parse (program [0, 0] - [1, 0] (redirected_statement [0, 0] - [0, 20] body: (command [0, 0] - [0, 8] name: (command_name [0, 0] - [0, 2] (word [0, 0] - [0, 2])) argument: (word [0, 3] - [0, 8])) redirect: (file_redirect [0, 9] - [0, 20] destination: (word [0, 11] - [0, 20])))) ``` Solution: use `node.parent.text` for the pattern matching, which includes the full command ---- **2. bash always pattern lacks a space after the command** Approving `ls` adds `ls*` as an always pattern, which allows also other commands (e.g. `lsof`) which is not intended. Solution: add a space so `ls*` becomes `ls *` in the pattern
yindo added the pull-request label 2026-02-16 18:17:00 -05:00
yindo closed this issue 2026-02-16 18:17:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12074
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?