anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-23 02:36:57 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #6863] fix(lsp): add shell option for Dart LSP on Windows #12141

New Issue
Open
opened 2026-02-16 18:17:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:04 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/6863

State: open
Merged: No

Summary

Fixes the Dart LSP failing on Windows with "Command not found: dart" error by adding shell: true to the spawn options when running on Windows.

Problem

On Windows, the Dart LSP server fails to start even when dart is correctly installed and in PATH. The error occurs because:

  1. Bun.which("dart") finds a valid path (e.g., C:\Users\...\bin\dart.exe)
  2. However, spawn() without shell: true can fail on Windows for certain executable configurations

Solution

Add shell: process.platform === "win32" to the spawn options, following the same pattern used elsewhere in the codebase (e.g., npm.cmd handling in ESLint LSP).

Testing

  • Verified on Windows 10/11 with Dart SDK 3.5.4
  • Confirmed dart language-server --lsp works via shell
  • Minimal change, no impact on non-Windows platforms

Fixes #6861

cc @thdxr @adamdotdevin

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/6863 **State:** open **Merged:** No --- ## Summary Fixes the Dart LSP failing on Windows with "Command not found: dart" error by adding `shell: true` to the spawn options when running on Windows. ## Problem On Windows, the Dart LSP server fails to start even when `dart` is correctly installed and in PATH. The error occurs because: 1. `Bun.which("dart")` finds a valid path (e.g., `C:\Users\...\bin\dart.exe`) 2. However, `spawn()` without `shell: true` can fail on Windows for certain executable configurations ## Solution Add `shell: process.platform === "win32"` to the spawn options, following the same pattern used elsewhere in the codebase (e.g., `npm.cmd` handling in ESLint LSP). ## Testing - Verified on Windows 10/11 with Dart SDK 3.5.4 - Confirmed `dart language-server --lsp` works via shell - Minimal change, no impact on non-Windows platforms Fixes #6861 cc @thdxr @adamdotdevin
yindo added the pull-request label 2026-02-16 18:17:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12141
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?