anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #7113] fix(desktop): complete symlink support implementation and enable CI for PRs #12251

New Issue
Closed
opened 2026-02-16 18:17:10 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:10 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/7113

State: closed
Merged: Yes

Summary

  • Completes the symlink support fix from PR #7102 which was merged with compilation errors
  • Fixes get_sidecar_path() to use tauri::process::current_binary(&app.env())
  • Enables PR CI checks for nix-desktop workflow

Changes

  • packages/desktop/src-tauri/src/cli.rs:

    • Add use tauri::Manager; import for .env() access
    • Change get_sidecar_path() to accept app: &tauri::AppHandle parameter
    • Use tauri::process::current_binary(&app.env()) instead of current_exe()
    • Update install_cli() to pass through AppHandle

  • packages/desktop/src-tauri/src/lib.rs:

    • Pass app parameter to get_sidecar_path(app) call

  • .github/workflows/nix-desktop.yml:

    • Add pull_request trigger to enable CI on PRs

Context

PR #7102 was merged but had a compilation error because tauri::process::current_binary() requires a parameter. This PR fixes that issue by properly passing the app environment through the call chain.

Testing

  • CI builds will validate the fix compiles on Ubuntu and macOS

Completes #7102

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/7113 **State:** closed **Merged:** Yes --- ## Summary - Completes the symlink support fix from PR #7102 which was merged with compilation errors - Fixes `get_sidecar_path()` to use `tauri::process::current_binary(&app.env())` - Enables PR CI checks for nix-desktop workflow ## Changes - **packages/desktop/src-tauri/src/cli.rs**: - Add `use tauri::Manager;` import for `.env()` access - Change `get_sidecar_path()` to accept `app: &tauri::AppHandle` parameter - Use `tauri::process::current_binary(&app.env())` instead of `current_exe()` - Update `install_cli()` to pass through `AppHandle` - **packages/desktop/src-tauri/src/lib.rs**: - Pass `app` parameter to `get_sidecar_path(app)` call - **.github/workflows/nix-desktop.yml**: - Add `pull_request` trigger to enable CI on PRs ## Context PR #7102 was merged but had a compilation error because `tauri::process::current_binary()` requires a parameter. This PR fixes that issue by properly passing the app environment through the call chain. ## Testing - CI builds will validate the fix compiles on Ubuntu and macOS Completes #7102
yindo added the pull-request label 2026-02-16 18:17:10 -05:00
yindo closed this issue 2026-02-16 18:17:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12251
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?