anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #7424] fix: force kill MCP server processes on dispose to prevent orphan processes #12395

New Issue
Open
opened 2026-02-16 18:17:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/7424

State: open
Merged: No

Relates to #3013, #7261

Summary

  • Track local MCP server transports to enable forceful process termination
  • Add forceKillProcess() helper for cross-platform process termination
  • Force kill remaining MCP processes on dispose after graceful close timeout
  • Check if process is alive before attempting force kill

Problem

The MCP SDK's client.close() uses AbortController.abort() which may not work reliably for:

  • Docker containers without --init flag
  • Hung or unresponsive processes
  • Processes that don't handle signals properly

Solution

Defensive fallback that only triggers if graceful close doesn't work:

  1. Try graceful client.close() with 2 second timeout
  2. Check if process is still alive
  3. Force kill only if still running

Testing

Added tests in test/mcp/process-cleanup.test.ts.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/7424 **State:** open **Merged:** No --- Relates to #3013, #7261 ## Summary - Track local MCP server transports to enable forceful process termination - Add `forceKillProcess()` helper for cross-platform process termination - Force kill remaining MCP processes on dispose after graceful close timeout - Check if process is alive before attempting force kill ## Problem The MCP SDK's `client.close()` uses `AbortController.abort()` which may not work reliably for: - Docker containers without `--init` flag - Hung or unresponsive processes - Processes that don't handle signals properly ## Solution Defensive fallback that only triggers if graceful close doesn't work: 1. Try graceful `client.close()` with 2 second timeout 2. Check if process is still alive 3. Force kill only if still running ## Testing Added tests in `test/mcp/process-cleanup.test.ts`.
yindo added the pull-request label 2026-02-16 18:17:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?