anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #7734] feat(storage): atomic writes, repair/restore CLI, safe temp cleanup #12494

New Issue
Open
opened 2026-02-16 18:17:24 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:24 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/7734

State: open
Merged: No

What

  • Make writes atomic with fsync(file)+rename+fsync(dir).
  • Safe cleanup for .oc-*.tmp only.
  • Extend storage repair with dry-run, prefix, limits, JSON report.
  • Add storage restore to recover from quarantine.

Why

  • Prevent partial JSON corruption.
  • Provide operable, auditable recovery with minimal risk.

Details

  • Fallback to Node fs.fsync if FileHandle.sync() is absent.
  • repair coordinates with writers using Lock.tryWrite(); busy files are skipped and reported.
  • Report fields: time, base, quarantined, tempRemoved, skippedLocked, processed*, entries.

DX

  • JSON-only output for scripting; flags documented in --help.

Tests

  • Added tests for dry-run/restore and temp cleanup pattern.
  • Roundtrip validation for read/write unchanged.

Risks/Trade-offs

  • Slight I/O overhead; acceptable for consistency.
  • Best-effort semantics on non-POSIX FS are documented.

Follow-ups

  • Optional: quarantine retention policy.
  • Optional: global maintenance lock.
  • Optional: schema sentinel for semantic corruption.

Closes https://github.com/anomalyco/opencode/issues/7733

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/7734 **State:** open **Merged:** No --- What - Make writes atomic with fsync(file)+rename+fsync(dir). - Safe cleanup for .oc-*.tmp only. - Extend storage repair with dry-run, prefix, limits, JSON report. - Add storage restore to recover from quarantine. Why - Prevent partial JSON corruption. - Provide operable, auditable recovery with minimal risk. Details - Fallback to Node fs.fsync if FileHandle.sync() is absent. - repair coordinates with writers using Lock.tryWrite(); busy files are skipped and reported. - Report fields: time, base, quarantined, tempRemoved, skippedLocked, processed*, entries. DX - JSON-only output for scripting; flags documented in --help. Tests - Added tests for dry-run/restore and temp cleanup pattern. - Roundtrip validation for read/write unchanged. Risks/Trade-offs - Slight I/O overhead; acceptable for consistency. - Best-effort semantics on non-POSIX FS are documented. Follow-ups - Optional: quarantine retention policy. - Optional: global maintenance lock. - Optional: schema sentinel for semantic corruption. Closes https://github.com/anomalyco/opencode/issues/7733
yindo added the pull-request label 2026-02-16 18:17:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12494
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?