anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #7888] fix(storage): handle empty JSON files gracefully #12553

New Issue
Closed
opened 2026-02-16 18:17:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:27 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/7888

State: closed
Merged: No

Fixes #7889
Fixes #7715

Summary

Fixed "Unexpected end of JSON input" and "Unterminated string" errors in storage and SDK client.

1. SDK Client (both v1 and v2 client.gen.ts)

  • Handle empty responses with proper JSON parsing check
  • Added try-catch with contextual error messages for malformed JSON

2. Storage Layer - Empty Files (storage.ts - commit 23848ed32)

  • Handle empty JSON files gracefully in read() and update() functions
  • Check for empty files before parsing, throw NotFoundError instead of JSON parse error

3. Storage Layer - Corrupted Files (storage.ts - commit 061652ed3)

  • NEW: Detect null bytes and control characters in JSON files
  • NEW: Comprehensive JSON parse error handling with descriptive messages
  • NEW: Make stats command resilient to corrupted files

Root Cause (Corrupted Files)

Found 3 production storage files containing 1518 null bytes each instead of valid JSON:

  • .trim() check only catches whitespace, not null bytes
  • JSON.parse() crashed with "Unterminated string" error
  • stats command failed because Promise.all() had no error handling

Changes

SDK Client

// Read response as text first, only parse JSON if non-empty
const text = await response.text()
if (!text) return undefined
data = JSON.parse(text)

Storage - Empty File Check

const content = await Bun.file(target).text()
if (!content.trim()) {
  throw new NotFoundError({ message: `Empty file: ${target}` })
}

Storage - Corruption Detection (NEW)

// Detect null bytes and control characters
const hasControlCharacters = /[\x00-\x08\x0B\x0C\x0E-\x1F]/.test(content)
if (hasControlCharacters) {
  throw new NotFoundError({ message: `Corrupted file detected: ${target}` })
}

// Wrap JSON.parse with error handling
try {
  const result = JSON.parse(content)
  return result as T
} catch (e) {
  const message = e instanceof Error ? e.message : String(e)
  throw new NotFoundError({ message: `Failed to parse JSON from ${target}: ${message}` })
}

Stats Command Resilience (NEW)

// Skip corrupted files gracefully instead of crashing
const projects = await Promise.all(
  projectKeys.map((key) => Storage.read<Project.Info>(key).catch(() => undefined))
)

Testing

  • ✅ Detected and handled 3 corrupted files in production storage
  • ✅ opencode-dev stats works (processed 4,773 sessions successfully)
  • ✅ All type checks pass
  • ✅ Empty file handling works as expected

Files Changed

  • packages/opencode/src/storage/storage.ts - Empty + corrupted file handling
  • packages/opencode/src/cli/cmd/stats.ts - Resilient error handling
  • SDK client files (auto-generated) - Empty response handling
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/7888 **State:** closed **Merged:** No --- Fixes #7889 Fixes #7715 ## Summary Fixed "Unexpected end of JSON input" and "Unterminated string" errors in storage and SDK client. ### 1. SDK Client (both v1 and v2 `client.gen.ts`) - Handle empty responses with proper JSON parsing check - Added try-catch with contextual error messages for malformed JSON ### 2. Storage Layer - Empty Files (`storage.ts` - commit 23848ed32) - Handle empty JSON files gracefully in `read()` and `update()` functions - Check for empty files before parsing, throw `NotFoundError` instead of JSON parse error ### 3. Storage Layer - Corrupted Files (`storage.ts` - commit 061652ed3) - **NEW:** Detect null bytes and control characters in JSON files - **NEW:** Comprehensive JSON parse error handling with descriptive messages - **NEW:** Make `stats` command resilient to corrupted files ## Root Cause (Corrupted Files) Found 3 production storage files containing **1518 null bytes each** instead of valid JSON: - `.trim()` check only catches whitespace, not null bytes - `JSON.parse()` crashed with "Unterminated string" error - `stats` command failed because `Promise.all()` had no error handling ## Changes ### SDK Client ```typescript // Read response as text first, only parse JSON if non-empty const text = await response.text() if (!text) return undefined data = JSON.parse(text) ``` ### Storage - Empty File Check ```typescript const content = await Bun.file(target).text() if (!content.trim()) { throw new NotFoundError({ message: `Empty file: ${target}` }) } ``` ### Storage - Corruption Detection (NEW) ```typescript // Detect null bytes and control characters const hasControlCharacters = /[\x00-\x08\x0B\x0C\x0E-\x1F]/.test(content) if (hasControlCharacters) { throw new NotFoundError({ message: `Corrupted file detected: ${target}` }) } // Wrap JSON.parse with error handling try { const result = JSON.parse(content) return result as T } catch (e) { const message = e instanceof Error ? e.message : String(e) throw new NotFoundError({ message: `Failed to parse JSON from ${target}: ${message}` }) } ``` ### Stats Command Resilience (NEW) ```typescript // Skip corrupted files gracefully instead of crashing const projects = await Promise.all( projectKeys.map((key) => Storage.read<Project.Info>(key).catch(() => undefined)) ) ``` ## Testing - ✅ Detected and handled 3 corrupted files in production storage - ✅ `opencode-dev stats` works (processed 4,773 sessions successfully) - ✅ All type checks pass - ✅ Empty file handling works as expected ## Files Changed - `packages/opencode/src/storage/storage.ts` - Empty + corrupted file handling - `packages/opencode/src/cli/cmd/stats.ts` - Resilient error handling - SDK client files (auto-generated) - Empty response handling
yindo added the pull-request label 2026-02-16 18:17:27 -05:00
yindo closed this issue 2026-02-16 18:17:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12553
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?