anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8075] fix: await auth.set to prevent race condition when setting API key #12611

New Issue
Closed
opened 2026-02-16 18:17:30 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:30 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8075

State: closed
Merged: Yes

Summary

Fixes #8073

  • Added await to the auth.set() call in the /model dialog to ensure the API key is persisted before instance.dispose() and sync.bootstrap() run

Root Cause

The auth.set() call was not being awaited, causing a race condition where the bootstrap would happen before the auth data was written to disk. This resulted in the API key not being loaded after entry, requiring a restart.

Reproduction of the bug

https://github.com/user-attachments/assets/e2285eca-bb87-4590-bcce-67c21ae00b96

Bug fix

https://github.com/user-attachments/assets/7ced70c2-6723-4fb9-a849-23829adcf720

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8075 **State:** closed **Merged:** Yes --- ## Summary Fixes #8073 - Added `await` to the `auth.set()` call in the `/model` dialog to ensure the API key is persisted before `instance.dispose()` and `sync.bootstrap()` run ## Root Cause The `auth.set()` call was not being awaited, causing a race condition where the bootstrap would happen before the auth data was written to disk. This resulted in the API key not being loaded after entry, requiring a restart. ## Reproduction of the bug https://github.com/user-attachments/assets/e2285eca-bb87-4590-bcce-67c21ae00b96 ## Bug fix https://github.com/user-attachments/assets/7ced70c2-6723-4fb9-a849-23829adcf720
yindo added the pull-request label 2026-02-16 18:17:30 -05:00
yindo closed this issue 2026-02-16 18:17:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12611
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?