anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8111] fix(task): respect agent task permission for nested sub-agents #12628

New Issue
Closed
opened 2026-02-16 18:17:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:31 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8111

State: closed
Merged: Yes

Fixes #8114

What does this PR do?

Restores the ability for agents to control the task tool via permission frontmatter.

The permission rework in #6319 removed the ...agent.tools spread that allowed agents to override the default task: false. This fix checks if the agent has any task permission rule defined - if so, we don't add our default deny, letting the agent's permission take effect.

Examples:

  • permission: { task: allow } → can spawn any sub-agent
  • permission: { task: { researcher: allow } } → can only spawn researcher
  • permission: { task: deny } → explicitly denied
  • No task permission → default deny (unchanged behavior)

How did you verify your code works?

  • bun test task - 21 tests pass
  • bun test permission - 82 tests pass
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8111 **State:** closed **Merged:** Yes --- Fixes #8114 ### What does this PR do? Restores the ability for agents to control the task tool via permission frontmatter. The permission rework in #6319 removed the `...agent.tools` spread that allowed agents to override the default `task: false`. This fix checks if the agent has any task permission rule defined - if so, we don't add our default deny, letting the agent's permission take effect. **Examples:** - `permission: { task: allow }` → can spawn any sub-agent - `permission: { task: { researcher: allow } }` → can only spawn researcher - `permission: { task: deny }` → explicitly denied - No task permission → default deny (unchanged behavior) ### How did you verify your code works? - `bun test task` - 21 tests pass - `bun test permission` - 82 tests pass
yindo added the pull-request label 2026-02-16 18:17:31 -05:00
yindo closed this issue 2026-02-16 18:17:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?