anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8147] fix(tui): prevent question tool keybindings when dialog is open #12638

New Issue
Closed
opened 2026-02-16 18:17:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:32 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8147

State: closed
Merged: Yes

What does this PR do?

Fixes the keyboard binding conflict where the Question tool's H/L navigation keys interfere with typing in the command palette.

When the Question tool is active and the user opens the command palette (Ctrl+P), pressing h or l would navigate the question tabs instead of typing in the command palette's search input.

This change adds a guard at the start of the useKeyboard handler to skip event processing when a dialog is open, following the established pattern used in dialog-command.tsx (lines 48 and 103).

Fixes #8118

How did you verify your code works?

  • Verified the fix follows the exact pattern established in dialog-command.tsx
  • The change uses the already-imported and instantiated dialog context from useDialog()
  • Minimal change: adds only 3 lines to check dialog.stack.length > 0 before processing

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8147 **State:** closed **Merged:** Yes --- ### What does this PR do? Fixes the keyboard binding conflict where the Question tool's H/L navigation keys interfere with typing in the command palette. When the Question tool is active and the user opens the command palette (Ctrl+P), pressing `h` or `l` would navigate the question tabs instead of typing in the command palette's search input. This change adds a guard at the start of the `useKeyboard` handler to skip event processing when a dialog is open, following the established pattern used in `dialog-command.tsx` (lines 48 and 103). Fixes #8118 ### How did you verify your code works? - Verified the fix follows the exact pattern established in `dialog-command.tsx` - The change uses the already-imported and instantiated `dialog` context from `useDialog()` - Minimal change: adds only 3 lines to check `dialog.stack.length > 0` before processing --- 🤖 Generated with [Claude Code](https://claude.com/claude-code)
yindo added the pull-request label 2026-02-16 18:17:32 -05:00
yindo closed this issue 2026-02-16 18:17:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12638
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?