anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8254] fix(tui): clean up SDK event listeners on unmount #12678

New Issue
Open
opened 2026-02-16 18:17:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8254

State: open
Merged: No

Summary

Fix memory leak in the TUI App component where SDK event listeners (onStdout, onStderr, onMessage, onFinished) are never unsubscribed.

Problem

In packages/tui/src/app.tsx, the useEffect hook sets up event listeners via sdk.on() calls but the cleanup function only calls sdk.stop() without removing the listeners. This causes:

  • Event listener accumulation over time
  • Memory retention of closed sessions
  • Potential duplicate event handling

Solution

  • Store unsubscribe functions returned by sdk.on()
  • Call all unsubscribe functions in the cleanup return
  • Ensures proper cleanup when component unmounts or session changes

Fixes #8258

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8254 **State:** open **Merged:** No --- ## Summary Fix memory leak in the TUI App component where SDK event listeners (onStdout, onStderr, onMessage, onFinished) are never unsubscribed. ## Problem In `packages/tui/src/app.tsx`, the `useEffect` hook sets up event listeners via `sdk.on()` calls but the cleanup function only calls `sdk.stop()` without removing the listeners. This causes: - Event listener accumulation over time - Memory retention of closed sessions - Potential duplicate event handling ## Solution - Store unsubscribe functions returned by `sdk.on()` - Call all unsubscribe functions in the cleanup return - Ensures proper cleanup when component unmounts or session changes Fixes #8258
yindo added the pull-request label 2026-02-16 18:17:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?