anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8310] fix(grep): return lines even in the presence of warnings #12699

New Issue
Closed
opened 2026-02-16 18:17:35 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:35 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8310

State: closed
Merged: No

What does this PR do?

Fixes #8307 by modifying the Grep tool so that an error is only returned if ripgrep's stdout is empty, in addition to checking the status code.

This might not be the solution you all want, since it doesn't enable the model to get the potentially useful warning messages out of the tool call.

How did you verify your code works?

Added some unit tests, and recreated the scenario here: https://opncd.ai/share/9YARWprF. Create a broken symlink, and then ask the model to grep in the root of the repo.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8310 **State:** closed **Merged:** No --- ### What does this PR do? Fixes #8307 by modifying the `Grep` tool so that an error is only returned if `ripgrep`'s stdout is empty, in addition to checking the status code. This might not be the solution you all want, since it doesn't enable the model to get the potentially useful warning messages out of the tool call. ### How did you verify your code works? Added some unit tests, and recreated the scenario here: https://opncd.ai/share/9YARWprF. Create a broken symlink, and then ask the model to grep in the root of the repo.
yindo added the pull-request label 2026-02-16 18:17:35 -05:00
yindo closed this issue 2026-02-16 18:17:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12699
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?