anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8356] fix(opencode): preserve model favorites on startup #12718

New Issue
Closed
opened 2026-02-16 18:17:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:37 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8356

State: closed
Merged: No

Fixes #8375

Summary

  • defer model.json writes until model state is ready to avoid overwriting saved favorites
  • merge and normalize persisted recents/favorites/variants with in-memory state on load

Root Cause

Race condition in local.tsx: save() can run before model.json is loaded, writing empty favorites to disk.

Changes

  • Add pendingSave flag to queue writes until ready
  • Add isModelEntry, normalizeModelList, normalizeVariant helpers for defensive parsing
  • Merge loaded state with in-memory state (preserves early user actions)
  • Flush queued save after file load completes
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8356 **State:** closed **Merged:** No --- Fixes #8375 ## Summary - defer `model.json` writes until model state is ready to avoid overwriting saved favorites - merge and normalize persisted recents/favorites/variants with in-memory state on load ## Root Cause Race condition in `local.tsx`: `save()` can run before `model.json` is loaded, writing empty favorites to disk. ## Changes - Add `pendingSave` flag to queue writes until ready - Add `isModelEntry`, `normalizeModelList`, `normalizeVariant` helpers for defensive parsing - Merge loaded state with in-memory state (preserves early user actions) - Flush queued save after file load completes
yindo added the pull-request label 2026-02-16 18:17:37 -05:00
yindo closed this issue 2026-02-16 18:17:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12718
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?