anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8414] fix: escape data-key values for querySelector compatibility #12735

New Issue
Closed
opened 2026-02-16 18:17:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:37 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8414

State: closed
Merged: No

What does this PR do?

Fix #7408 #7670

Fixes a critical syntax error in the List component when using querySelector with data-key attributes containing special characters, spaces, quotes, or non-ASCII characters (like Chinese). The issue occurred because raw key values were being inserted directly into CSS selector strings without proper escaping.

How did you verify your code works?

  1. Added comprehensive unit tests: Created list.test.tsx with test cases covering:
    • File names with spaces
    • File names with single quotes
    • File names with special symbols (#, @, $, ^, &)
    • Non-ASCII Chinese file names
  2. Manual testing: Verified component functionality with various edge case key values
  3. Type safety: Ensured TypeScript compatibility with CSS.escape() usage
  4. Regression testing: Confirmed existing List component behavior remains unchanged
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8414 **State:** closed **Merged:** No --- ### What does this PR do? Fix #7408 #7670 Fixes a critical syntax error in the List component when using querySelector with data-key attributes containing special characters, spaces, quotes, or non-ASCII characters (like Chinese). The issue occurred because raw key values were being inserted directly into CSS selector strings without proper escaping. ### How did you verify your code works? 1. **Added comprehensive unit tests**: Created `list.test.tsx` with test cases covering: - File names with spaces - File names with single quotes - File names with special symbols (#, @, $, ^, &) - Non-ASCII Chinese file names 2. **Manual testing**: Verified component functionality with various edge case key values 3. **Type safety**: Ensured TypeScript compatibility with CSS.escape() usage 4. **Regression testing**: Confirmed existing List component behavior remains unchanged
yindo added the pull-request label 2026-02-16 18:17:37 -05:00
yindo closed this issue 2026-02-16 18:17:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?