anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8451] fix: publish session.error event for invalid model selection #12747

New Issue
Closed
opened 2026-02-16 18:17:38 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:38 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8451

State: closed
Merged: Yes

Fix: Publish session.error event for invalid model selection

Problem

When sending a message via the API with an invalid provider or model ID, the error was silently swallowed. API consumers had no way to know something went wrong.

What happened:

  1. POST to /session/{id}/message with { model: { providerID: "invalid", ... } }
  2. HTTP response returns 200 immediately (before validation)
  3. User message is created successfully
  4. Session goes busy → idle with no error indication
  5. No session.error event is published to /event

Root cause: The Provider.getModel() call happens inside loop() after the HTTP response has already started streaming. When it throws ModelNotFoundError, the error propagates up but is never converted to a session.error event.

Solution

Added error handling around Provider.getModel() in loop() to publish a session.error event before re-throwing. This matches the existing pattern used in the command() function.

After this fix:

data: {"type":"session.error","properties":{"sessionID":"ses_...","error":{"name":"UnknownError","data":{"message":"Model not found: invalid/some-model. Did you mean: anthropic, openai, ...?"}}}}

Changes

  • packages/opencode/src/session/prompt.ts: Wrap Provider.getModel() in try-catch, publish session.error on ModelNotFoundError

Fixes #8460

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8451 **State:** closed **Merged:** Yes --- # Fix: Publish session.error event for invalid model selection ## Problem When sending a message via the API with an invalid provider or model ID, the error was silently swallowed. API consumers had no way to know something went wrong. **What happened:** 1. POST to `/session/{id}/message` with `{ model: { providerID: "invalid", ... } }` 2. HTTP response returns 200 immediately (before validation) 3. User message is created successfully 4. Session goes `busy` → `idle` with no error indication 5. No `session.error` event is published to `/event` **Root cause:** The `Provider.getModel()` call happens inside `loop()` after the HTTP response has already started streaming. When it throws `ModelNotFoundError`, the error propagates up but is never converted to a `session.error` event. ## Solution Added error handling around `Provider.getModel()` in `loop()` to publish a `session.error` event before re-throwing. This matches the existing pattern used in the `command()` function. **After this fix:** ``` data: {"type":"session.error","properties":{"sessionID":"ses_...","error":{"name":"UnknownError","data":{"message":"Model not found: invalid/some-model. Did you mean: anthropic, openai, ...?"}}}} ``` ## Changes - `packages/opencode/src/session/prompt.ts`: Wrap `Provider.getModel()` in try-catch, publish `session.error` on `ModelNotFoundError` Fixes #8460
yindo added the pull-request label 2026-02-16 18:17:38 -05:00
yindo closed this issue 2026-02-16 18:17:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?