anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8658] feat: add litellmProxy provider option for explicit LiteLLM compatibility #12823

New Issue
Closed
opened 2026-02-16 18:17:43 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:43 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8658

State: closed
Merged: Yes

Summary

This PR builds on #8497 and addresses @rekram1-node's feedback from #8248:

"There are a LOT of providers that don't have this issue... ideally this would be strictly limited to litellm"

Instead of injecting the _noop tool unconditionally for all providers, this change restricts it to only LiteLLM-backed providers.

Problem

#8497 injects the _noop tool unconditionally when message history contains tool calls. While this fixes the LiteLLM compatibility issue, it unnecessarily affects providers that don't need it (Anthropic native, OpenRouter, Vertex, Bedrock, etc).

Solution

Add litellmProxy provider option and restrict _noop injection to LiteLLM providers:

const isLiteLLMProxy =
  provider.options?.["litellmProxy"] === true ||
  input.model.providerID.toLowerCase().includes("litellm") ||
  input.model.api.id.toLowerCase().includes("litellm")

if (isLiteLLMProxy && Object.keys(tools).length === 0 && hasToolCalls(input.messages)) {
  tools["_noop"] = tool({ ... })
}

Detection methods:

  1. Auto-detect: Provider ID or API ID contains "litellm"
  2. Explicit opt-in: Provider has litellmProxy: true option (for custom gateways)

Config example:

{
  "provider": {
    "my-gateway": {
      "api": "openai",
      "options": {
        "litellmProxy": true
      }
    }
  }
}

Changes

File Change
packages/opencode/src/session/llm.ts Add isLiteLLMProxy check with auto-detection + opt-in support
packages/opencode/src/session/message-v2.ts Handle pending/running tool calls (from #8497)
packages/opencode/test/session/llm.test.ts Tests for hasToolCalls helper (from #8497)
packages/opencode/test/session/message-v2.test.ts Tests for pending/running tool conversion (from #8497)

Testing

  • All tests pass (18 tests across 2 files)
  • Manual testing with custom LiteLLM gateway confirmed working

Related

Co-authored-by: Mark Henderson Mark.Henderson99@hotmail.com

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8658 **State:** closed **Merged:** Yes --- ## Summary This PR builds on #8497 and addresses @rekram1-node's feedback from #8248: > "There are a LOT of providers that don't have this issue... ideally this would be strictly limited to litellm" Instead of injecting the `_noop` tool unconditionally for all providers, this change restricts it to only LiteLLM-backed providers. ## Problem #8497 injects the `_noop` tool unconditionally when message history contains tool calls. While this fixes the LiteLLM compatibility issue, it unnecessarily affects providers that don't need it (Anthropic native, OpenRouter, Vertex, Bedrock, etc). ## Solution Add `litellmProxy` provider option and restrict `_noop` injection to LiteLLM providers: ```typescript const isLiteLLMProxy = provider.options?.["litellmProxy"] === true || input.model.providerID.toLowerCase().includes("litellm") || input.model.api.id.toLowerCase().includes("litellm") if (isLiteLLMProxy && Object.keys(tools).length === 0 && hasToolCalls(input.messages)) { tools["_noop"] = tool({ ... }) } ``` **Detection methods:** 1. **Auto-detect**: Provider ID or API ID contains "litellm" 2. **Explicit opt-in**: Provider has `litellmProxy: true` option (for custom gateways) **Config example:** ```json { "provider": { "my-gateway": { "api": "openai", "options": { "litellmProxy": true } } } } ``` ## Changes | File | Change | |------|--------| | `packages/opencode/src/session/llm.ts` | Add `isLiteLLMProxy` check with auto-detection + opt-in support | | `packages/opencode/src/session/message-v2.ts` | Handle pending/running tool calls (from #8497) | | `packages/opencode/test/session/llm.test.ts` | Tests for `hasToolCalls` helper (from #8497) | | `packages/opencode/test/session/message-v2.test.ts` | Tests for pending/running tool conversion (from #8497) | ## Testing - All tests pass (18 tests across 2 files) - Manual testing with custom LiteLLM gateway confirmed working ## Related - Builds on #8497 - Addresses feedback from #8248 - Fixes #8246 - Fixes #2915 Co-authored-by: Mark Henderson <Mark.Henderson99@hotmail.com>
yindo added the pull-request label 2026-02-16 18:17:43 -05:00
yindo closed this issue 2026-02-16 18:17:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12823
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?