anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8828] fix(core): handle macro data as string in built artifacts #12884

New Issue
Closed
opened 2026-02-16 18:17:46 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:46 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8828

State: closed
Merged: No

Adds check for string type to handle Bun macros inlined at build time.

Changes

Modified the type check to include both function and string types:

// Before
if (typeof data === 'function') {
  const json = await data()
  return JSON.parse(json) as Record<string, Provider>
}

// After  
if (typeof data === 'function' || typeof data === 'string') {
  const json = await data()
  return JSON.parse(json) as Record<string, Provider>
}

Context

When Bun macros are enabled during compilation, the data() function may be executed and inlined as a string literal in the built artifacts. The original code only checked for function type, missing the string case.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8828 **State:** closed **Merged:** No --- Adds check for string type to handle Bun macros inlined at build time. ## Changes Modified the type check to include both function and string types: ```typescript // Before if (typeof data === 'function') { const json = await data() return JSON.parse(json) as Record<string, Provider> } // After if (typeof data === 'function' || typeof data === 'string') { const json = await data() return JSON.parse(json) as Record<string, Provider> } ``` ## Context When Bun macros are enabled during compilation, the `data()` function may be executed and inlined as a string literal in the built artifacts. The original code only checked for function type, missing the string case.
yindo added the pull-request label 2026-02-16 18:17:46 -05:00
yindo closed this issue 2026-02-16 18:17:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12884
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?