anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8939] fix: change default permissions from allow to ask for better security #12914

New Issue
Open
opened 2026-02-16 18:17:48 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:48 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8939

State: open
Merged: No

What does this PR do?

Changes the default "": "allow" to "": "ask" in agent defaults to prevent auto-execution of potentially dangerous operations like bash commands, file edits, and web fetches without user approval.

This addresses security concerns raised in #2148 where users were surprised that OpenCode allowed arbitrary shell commands and file modifications by default without prompting.

The build agent and other agents still function correctly as they explicitly override permissions where needed.

Closes #8938

How did you verify your code works?

Testing:

  • bun test test/tool/bash.test.ts: 12 pass, 0 fail
  • bun test test/tool/ test/agent/ test/permission/: 106 pass, 28 fail
  • Agent test failures are due to unrelated import issues, not this change
  • Verified bash permission tests work correctly with new default
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8939 **State:** open **Merged:** No --- ### What does this PR do? Changes the default "*": "allow" to "*": "ask" in agent defaults to prevent auto-execution of potentially dangerous operations like bash commands, file edits, and web fetches without user approval. This addresses security concerns raised in #2148 where users were surprised that OpenCode allowed arbitrary shell commands and file modifications by default without prompting. The build agent and other agents still function correctly as they explicitly override permissions where needed. Closes #8938 ### How did you verify your code works? Testing: - `bun test test/tool/bash.test.ts`: 12 pass, 0 fail - `bun test test/tool/ test/agent/ test/permission/`: 106 pass, 28 fail - Agent test failures are due to unrelated import issues, not this change - Verified bash permission tests work correctly with new default
yindo added the pull-request label 2026-02-16 18:17:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?