anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-23 02:36:57 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #9039] fix: mdns discover hostname #12959

New Issue
Closed
opened 2026-02-16 18:17:50 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:50 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/9039

State: closed
Merged: Yes

Fix: #9040

What does this PR do?

  1. Adds explicit hostname to mDNS publication - Sets host: "opencode.local" when publishing the mDNS service,
    ensuring the service is advertised with the correct discoverable hostname.
  2. Simplifies the MDNS.publish API - Moves the service name generation (opencode-${port}) inside the function,
    removing the optional name parameter since it was always being overridden by the caller anyway.
  3. Fixes CLI display - Updates the mDNS info message to show the full address including the port
    (opencode.local:${server.port}) instead of just opencode.local.

How did you verify your code works?

  • Running the web server with mDNS enabled (--mdns flag)
  • Using dns-sd -B _http._tcp to verify the service is advertised with
    opencode.local as the hostname
  • Confirming the service is discoverable and resolves correctly on the local network
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/9039 **State:** closed **Merged:** Yes --- Fix: #9040 ### What does this PR do? 1. Adds explicit hostname to mDNS publication - Sets host: "opencode.local" when publishing the mDNS service, ensuring the service is advertised with the correct discoverable hostname. 2. Simplifies the MDNS.publish API - Moves the service name generation (opencode-${port}) inside the function, removing the optional name parameter since it was always being overridden by the caller anyway. 3. Fixes CLI display - Updates the mDNS info message to show the full address including the port (opencode.local:${server.port}) instead of just opencode.local. ### How did you verify your code works? - Running the web server with mDNS enabled (--mdns flag) - Using dns-sd -B _http._tcp to verify the service is advertised with opencode.local as the hostname - Confirming the service is discoverable and resolves correctly on the local network
yindo added the pull-request label 2026-02-16 18:17:50 -05:00
yindo closed this issue 2026-02-16 18:17:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?