anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #9435] feat: fix app list component jumping when mouse happens to be under the list and keyboard navigating. #13108

New Issue
Closed
opened 2026-02-16 18:17:58 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:58 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/9435

State: closed
Merged: Yes

What does this PR do?

This PR fixes an issue where if your mouse/pointer happened to be below the cmd+p/list and you attempt to use keyboard navigation the list would jump around.

NOTE this would only cause jumpiness if your mouse happens to be positioned over the list. If you tested without having the mouse under the list it would not exhibit this behavior.

Its reproducable in both Tauri and the web app.

The issue is that the onMouseLeave event was not guarded against when mouse was active or not. So as you navigated with the keyboard or filtered onMouseLeave events would fire and set an unactive item, which then triggers the useFilteredList to call reset thus reseting the active item.

By guarding this we dont call onMouseLeave unless the mouse is the active "navigation" method for the list which seems to be the intended behavior. This means it won't try to reset as the dom nodes move around underneath the mouse position.

Before - notice if you place the mouse under the dialog and then navigate with keyboard, as soon as the onmouseleave would fire (i.e. scrolling the least with the keyboard) it resets. This is because the reset fires in useFilteredList when the active item is unset

Jan-19-2026 10-27-14

Here is with the Fix

Jan-19-2026 10-28-01-fix

How did you verify your code works?

Manual verification running the app before and after the changes on both tauri and web.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/9435 **State:** closed **Merged:** Yes --- ### What does this PR do? This PR fixes an issue where if your mouse/pointer happened to be below the cmd+p/list and you attempt to use keyboard navigation the list would jump around. *NOTE* this would only cause jumpiness if your mouse happens to be positioned over the list. If you tested without having the mouse under the list it would not exhibit this behavior. Its reproducable in both Tauri and the web app. The issue is that the `onMouseLeave` event was not guarded against when mouse was active or not. So as you navigated with the keyboard or filtered onMouseLeave events would fire and set an unactive item, which then triggers the useFilteredList to call `reset` thus reseting the active item. By guarding this we dont call `onMouseLeave` unless the mouse is the active "navigation" method for the list which seems to be the intended behavior. This means it won't try to reset as the dom nodes move around underneath the mouse position. Before - notice if you place the mouse under the dialog and then navigate with keyboard, as soon as the onmouseleave would fire (i.e. scrolling the least with the keyboard) it resets. This is because the `reset` fires in useFilteredList when the active item is unset ![Jan-19-2026 10-27-14](https://github.com/user-attachments/assets/3d003901-492e-4096-ab9a-e0f68438bb9a) Here is with the Fix ![Jan-19-2026 10-28-01-fix](https://github.com/user-attachments/assets/c4b7a503-7b75-48dd-ad20-2887ac4754db) ### How did you verify your code works? Manual verification running the app before and after the changes on both tauri and web.
yindo added the pull-request label 2026-02-16 18:17:58 -05:00
yindo closed this issue 2026-02-16 18:17:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?