anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-23 02:36:57 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #9667] fix(opencode): preserve tool input from running state for MCP tool results #13179

New Issue
Closed
opened 2026-02-16 18:18:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:03 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/9667

State: closed
Merged: Yes

What does this PR do?

Fixes MCP tool results failing schema validation when the tool doesn't return input in the response.

When processing tool-result and tool-error events, value.input can be undefined for some MCP tools (e.g., chrome-devtools take_screenshot). This causes Zod schema validation to fail because ToolStateCompleted.input requires a record.

The fix preserves the input from the running tool state (match.state.input) when value.input is undefined.

Fixes #9666

How did you verify your code works?

  1. Configured chrome-devtools MCP with take_screenshot tool
  2. Before fix: calling screenshot without filePath fails with schema validation error
  3. After fix: screenshot completes successfully, input preserved from tool-call phase
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/9667 **State:** closed **Merged:** Yes --- ### What does this PR do? Fixes MCP tool results failing schema validation when the tool doesn't return `input` in the response. When processing `tool-result` and `tool-error` events, `value.input` can be undefined for some MCP tools (e.g., chrome-devtools `take_screenshot`). This causes Zod schema validation to fail because `ToolStateCompleted.input` requires a record. The fix preserves the input from the running tool state (`match.state.input`) when `value.input` is undefined. Fixes #9666 ### How did you verify your code works? 1. Configured chrome-devtools MCP with `take_screenshot` tool 2. Before fix: calling screenshot without `filePath` fails with schema validation error 3. After fix: screenshot completes successfully, input preserved from tool-call phase
yindo added the pull-request label 2026-02-16 18:18:03 -05:00
yindo closed this issue 2026-02-16 18:18:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13179
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?