anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #9940] fix(acp): rename setSessionModel to unstable_setSessionModel #13278

New Issue
Closed
opened 2026-02-16 18:18:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:08 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/9940

State: closed
Merged: Yes

Summary

Fixes #9941

  • Rename setSessionModel → unstable_setSessionModel to match ACP SDK v0.12.0+ interface
  • Add unit test to catch future SDK interface changes at compile time

Root Cause

The ACP TypeScript SDK v0.12.0 renamed this method in commit 7072d3f. The SDK's router checks if (!agent.unstable_setSessionModel) and throws "Method not found" when missing.

References

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/9940 **State:** closed **Merged:** Yes --- ## Summary Fixes #9941 - Rename `setSessionModel` → `unstable_setSessionModel` to match ACP SDK v0.12.0+ interface - Add unit test to catch future SDK interface changes at compile time ## Root Cause The ACP TypeScript SDK v0.12.0 renamed this method in [commit 7072d3f](https://github.com/agentclientprotocol/typescript-sdk/commit/7072d3f0aae8df8da4f772b3960268f3e7c43364). The SDK's router checks `if (!agent.unstable_setSessionModel)` and throws "Method not found" when missing. ## References - SDK commit: https://github.com/agentclientprotocol/typescript-sdk/commit/7072d3f - Same fix in Qwen Code: https://github.com/QwenLM/qwen-code/pull/1521
yindo added the pull-request label 2026-02-16 18:18:08 -05:00
yindo closed this issue 2026-02-16 18:18:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?