anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #10141] fix: handle non-array MCP tool result.content to prevent TypeError #13352

New Issue
Open
opened 2026-02-16 18:18:12 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:12 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/10141

State: open
Merged: No

Summary

Fixes TypeError: {} is not iterable error when MCP tools (like Claude's built-in discard and extract context management tools) return results with non-array content values.

Problem

In packages/opencode/src/session/prompt.ts:770, the code iterates over result.content assuming it's always an array:

for (const contentItem of result.content) {

When an MCP tool returns content as undefined, {}, or any non-array value, this throws:

TypeError: {} is not iterable

Solution

Added an Array.isArray() guard to safely handle non-array content:

const contentArray = Array.isArray(result.content) ? result.content : []
for (const contentItem of contentArray) {

Testing

Reproduced the error using Claude's built-in discard and extract tools, verified the fix prevents the error while maintaining correct behavior for standard MCP tool results.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/10141 **State:** open **Merged:** No --- ## Summary Fixes `TypeError: {} is not iterable` error when MCP tools (like Claude's built-in `discard` and `extract` context management tools) return results with non-array `content` values. ## Problem In `packages/opencode/src/session/prompt.ts:770`, the code iterates over `result.content` assuming it's always an array: ```typescript for (const contentItem of result.content) { ``` When an MCP tool returns `content` as `undefined`, `{}`, or any non-array value, this throws: ``` TypeError: {} is not iterable ``` ## Solution Added an `Array.isArray()` guard to safely handle non-array content: ```typescript const contentArray = Array.isArray(result.content) ? result.content : [] for (const contentItem of contentArray) { ``` ## Testing Reproduced the error using Claude's built-in `discard` and `extract` tools, verified the fix prevents the error while maintaining correct behavior for standard MCP tool results.
yindo added the pull-request label 2026-02-16 18:18:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?