anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #10156] fix(desktop): dialog not closing when clicking overlay during heavy r… #13361

New Issue
Closed
opened 2026-02-16 18:18:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:13 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/10156

State: closed
Merged: No

What does this PR do?

This PR adds a call to the "close" function on the setting dialog overlay to prevent the settings screen from being stuck. Fixes #10138 and #10137

How did you verify your code works?

I tested this by following the steps mentioned in the listed issues on the desktop client.

In the first video, you can see that the call to "openChangeDialog" doesn't work after the theme change, causing the dialog to remain open indefinitely. In the second video, you can see that the dialog is closed properly and the "overlay click" is logged in the console.

https://github.com/user-attachments/assets/d60a6b00-ffc6-4e9d-b408-c4ee1df3f942

https://github.com/user-attachments/assets/f7aa9351-399b-44b5-84c7-88fdbdcd1d7f

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/10156 **State:** closed **Merged:** No --- ### What does this PR do? This PR adds a call to the "close" function on the setting dialog overlay to prevent the settings screen from being stuck. Fixes #10138 and #10137 ### How did you verify your code works? I tested this by following the steps mentioned in the listed issues on the desktop client. In the first video, you can see that the call to "openChangeDialog" doesn't work after the theme change, causing the dialog to remain open indefinitely. In the second video, you can see that the dialog is closed properly and the "overlay click" is logged in the console. https://github.com/user-attachments/assets/d60a6b00-ffc6-4e9d-b408-c4ee1df3f942 https://github.com/user-attachments/assets/f7aa9351-399b-44b5-84c7-88fdbdcd1d7f
yindo added the pull-request label 2026-02-16 18:18:13 -05:00
yindo closed this issue 2026-02-16 18:18:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13361
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?