anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #10291] fix(app): normalize path separators for session diff filtering on Windows #13389

New Issue
Closed
opened 2026-02-16 18:18:15 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:15 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/10291

State: closed
Merged: Yes

fixes #9921

What does this PR do?

Normalizes path separators when comparing file paths in the session diff filtering logic. On Windows, path.relative() returns paths with backslashes (), but Git always outputs paths with forward slashes (/). This mismatch caused modified files to be filtered out of the session review on Windows.

The fix:
Added .replaceAll("\", "/") to normalize Windows backslashes to forward slashes before comparing against Git's output.

How did you verify your code works?

On Windows, started a new session, tested modify file, delete file and create file operations.

Before

Opencode review cannot see some files have been changed
image

After

Fixed
image

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/10291 **State:** closed **Merged:** Yes --- fixes #9921 ### What does this PR do? Normalizes path separators when comparing file paths in the session diff filtering logic. On Windows, path.relative() returns paths with backslashes (\), but Git always outputs paths with forward slashes (/). This mismatch caused modified files to be filtered out of the session review on Windows. The fix: Added .replaceAll("\\", "/") to normalize Windows backslashes to forward slashes before comparing against Git's output. ### How did you verify your code works? On Windows, started a new session, tested modify file, delete file and create file operations. ## Before Opencode review cannot see some files have been changed <img width="1325" height="582" alt="image" src="https://github.com/user-attachments/assets/23889e9b-d024-4b76-ab71-c6177bb5a0f6" /> ## After Fixed <img width="1384" height="769" alt="image" src="https://github.com/user-attachments/assets/d59aa91c-0b9e-42eb-ac55-8de5cc52b75e" />
yindo added the pull-request label 2026-02-16 18:18:15 -05:00
yindo closed this issue 2026-02-16 18:18:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13389
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?