anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #10565] fix(tui): prevent crash when theme search returns no results #13485

New Issue
Closed
opened 2026-02-16 18:18:20 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:20 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/10565

State: closed
Merged: Yes

What does this PR do?

Fixes #10488

When searching for themes in the TUI that don't exist, the DialogSelect component would crash with undefined is not an object (evaluating 'opt.value'). This happened because the onMove callback was being called even when the filtered options list was empty

Before

beforee

After

afteree

The fix adds a safety check in the moveTo function to only call onMove when there's actually a valid option selected.

How did you verify your code works?

  1. Run bun dev in the TUI
  2. Use /theme command
  3. Search for a theme that doesn't exist
  4. The dialog should show "No results found" without crashing

This is a minimal bug fix that follows the existing code patterns and doesn't change any external behavior.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/10565 **State:** closed **Merged:** Yes --- ### What does this PR do? Fixes #10488 When searching for themes in the TUI that don't exist, the DialogSelect component would crash with ```undefined is not an object (evaluating 'opt.value')```. This happened because the onMove callback was being called even when the filtered options list was empty ### Before ![beforee](https://github.com/user-attachments/assets/23ab38a9-394f-49d8-ab52-77943d5180e1) ### After ![afteree](https://github.com/user-attachments/assets/d8688fb3-90e0-4906-a02d-ed07913e1a51) The fix adds a safety check in the moveTo function to only call onMove when there's actually a valid option selected. ### How did you verify your code works? 1. Run bun dev in the TUI 2. Use /theme command 3. Search for a theme that doesn't exist 4. The dialog should show "No results found" without crashing This is a minimal bug fix that follows the existing code patterns and doesn't change any external behavior.
yindo added the pull-request label 2026-02-16 18:18:20 -05:00
yindo closed this issue 2026-02-16 18:18:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?