anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #10697] fix(app): restore external link opening in system browser #13527

New Issue
Closed
opened 2026-02-16 18:18:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:22 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/10697

State: closed
Merged: Yes

closes #10613
closes #8361

What does this PR do?

Restores the ability to open markdown links in the system browser instead of within the webview.

Problem

After the markdown parser was migrated from JavaScript to Rust, clicking links in markdown would navigate within the desktop app's webview instead of opening in the system browser.

The old implementation relied on:

  1. A module-level click event listener
  2. Filtering for links with the external-link class
  3. Using platform.openLink() to open them externally

Solution

Moved the external link handling into the component's onMount() hook to access
the platform
after the DOM is ready. Key improvements:

  • Catches ALL anchor clicks instead of filtering by class (more robust as
    markdown parser changed)
  • Uses stopPropagation() and stopImmediatePropagation() to prevent the
    webview's default link handling
  • Opens with shellOpen() from @tauri-apps/plugin-shell to open in system
    browser
  • Skips internal links (javascript: and # anchors) - but i don't think these are being used in the app as of now

How did you verify your code works?

Ran the app locally and clicked on links to verify they open in your system browser instead of inside the app window

Before

https://github.com/user-attachments/assets/eaae40ab-3ee0-40a6-be0a-e217b44d215c

After

https://github.com/user-attachments/assets/d89b166b-8c61-4715-a744-70b7dc75595b

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/10697 **State:** closed **Merged:** Yes --- closes #10613 closes #8361 ### What does this PR do? Restores the ability to open markdown links in the system browser instead of within the webview. ## Problem After the markdown parser was migrated from JavaScript to Rust, clicking links in markdown would navigate within the desktop app's webview instead of opening in the system browser. The old implementation relied on: 1. A module-level click event listener 2. Filtering for links with the `external-link` class 3. Using `platform.openLink()` to open them externally ## Solution Moved the external link handling into the component's `onMount()` hook to access the platform after the DOM is ready. Key improvements: - **Catches ALL anchor clicks** instead of filtering by class (more robust as markdown parser changed) - **Uses `stopPropagation()` and `stopImmediatePropagation()`** to prevent the webview's default link handling - **Opens with `shellOpen()`** from @tauri-apps/plugin-shell to open in system browser - **Skips internal links** (javascript: and # anchors) - but i don't think these are being used in the app as of now ### How did you verify your code works? Ran the app locally and clicked on links to verify they open in your system browser instead of inside the app window ## Before https://github.com/user-attachments/assets/eaae40ab-3ee0-40a6-be0a-e217b44d215c ## After https://github.com/user-attachments/assets/d89b166b-8c61-4715-a744-70b7dc75595b
yindo added the pull-request label 2026-02-16 18:18:22 -05:00
yindo closed this issue 2026-02-16 18:18:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13527
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?