anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-23 02:36:57 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #10734] fix(opencode): handle http/https URLs in file parts and prevent ENOENT crash #13544

New Issue
Open
opened 2026-02-16 18:18:23 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:23 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/10734

State: open
Merged: No

What does this PR do?

Fixes #10730

When a file part has an http: or https: URL (e.g., a GitHub image URL), the switch statement in createUserMessage had no matching case. If such a URL was ever wrapped in a file:// scheme, the unhandled Bun.file(filepath).stat() call would throw ENOENT and crash the TUI.

Two changes:

  1. Added case "http:" / case "https:" to the protocol switch — returns the part as-is instead of falling through silently
  2. Added .catch(() => undefined) to Bun.file(filepath).stat() in the file: case — if the file doesn't exist, returns a "File not found" text part instead of crashing

How did you verify your code works?

Traced the code path in packages/opencode/src/session/prompt.ts createUserMessage. The stat() call on line 953 (now 963) had no error handling — any ENOENT would propagate through Promise.all and crash. Verified the fix handles both cases: unknown protocols return gracefully, and missing files produce a user-visible message instead of a raw error dump.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/10734 **State:** open **Merged:** No --- ### What does this PR do? Fixes #10730 When a file part has an `http:` or `https:` URL (e.g., a GitHub image URL), the switch statement in `createUserMessage` had no matching case. If such a URL was ever wrapped in a `file://` scheme, the unhandled `Bun.file(filepath).stat()` call would throw ENOENT and crash the TUI. Two changes: 1. Added `case "http:"` / `case "https:"` to the protocol switch — returns the part as-is instead of falling through silently 2. Added `.catch(() => undefined)` to `Bun.file(filepath).stat()` in the `file:` case — if the file doesn't exist, returns a "File not found" text part instead of crashing ### How did you verify your code works? Traced the code path in `packages/opencode/src/session/prompt.ts` `createUserMessage`. The `stat()` call on line 953 (now 963) had no error handling — any ENOENT would propagate through `Promise.all` and crash. Verified the fix handles both cases: unknown protocols return gracefully, and missing files produce a user-visible message instead of a raw error dump.
yindo added the pull-request label 2026-02-16 18:18:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13544
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?