anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #10752] fix(app) internal/external link handling #13553

New Issue
Closed
opened 2026-02-16 18:18:24 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:24 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/10752

State: closed
Merged: No

Fixes #10613, #8361

What does this PR do?

fixes the external link handling issue that was reverted in #10697

The previous implementation broke internal app navigation (sessions, settings,
etc.) because it opened ALL links externally, regardless of whether they were
internal or external to the app.

Now properly distinguishes between internal and external links by comparing
origins.

Changes

  1. Desktop app: Fixed link interception to use origin comparison
  2. Web app: Added external link interception (opens in new tab)
  3. Tests: Added e2e test file

How did you verify your code works?

Tested in a dev desktop build, dev web build, and in a release desktop build

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/10752 **State:** closed **Merged:** No --- Fixes #10613, #8361 ### What does this PR do? fixes the external link handling issue that was reverted in #10697 The previous implementation broke internal app navigation (sessions, settings, etc.) because it opened ALL links externally, regardless of whether they were internal or external to the app. Now properly distinguishes between internal and external links by comparing origins. ## Changes 1. **Desktop app**: Fixed link interception to use origin comparison 2. **Web app**: Added external link interception (opens in new tab) 3. **Tests**: Added e2e test file ### How did you verify your code works? Tested in a dev desktop build, dev web build, and in a release desktop build
yindo added the pull-request label 2026-02-16 18:18:24 -05:00
yindo closed this issue 2026-02-16 18:18:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13553
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?