anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #11093] fix(tui): resolve EditBuffer destroyed error in dialog-select #13653

New Issue
Open
opened 2026-02-16 18:18:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:29 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/11093

State: open
Merged: No

Fixes #10926

Fixes race condition where input focus was called on a potentially stale reference before the EditBuffer was fully initialized.

What does this PR do?

The problem stems from a race condition where input.focus() was being called on a potationally stale closure variable before EditBuffer was fully initialized. Changing to queueMicrotask instead of setTimeout for more immediate execution and r.focus() instead of input.focus() to ensure we're focusing the instance that was just created.

How did you verify your code works?

Verified by testing provider connection flow (Moonshot AI) which previously crashed with "EditBuffer is destroyed" error.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/11093 **State:** open **Merged:** No --- Fixes #10926 Fixes race condition where input focus was called on a potentially stale reference before the EditBuffer was fully initialized. ### What does this PR do? The problem stems from a race condition where `input.focus()` was being called on a potationally stale closure variable before EditBuffer was fully initialized. Changing to `queueMicrotask` instead of `setTimeout` for more immediate execution and `r.focus()` instead of `input.focus()` to ensure we're focusing the instance that was just created. ### How did you verify your code works? Verified by testing provider connection flow (Moonshot AI) which previously crashed with "EditBuffer is destroyed" error.
yindo added the pull-request label 2026-02-16 18:18:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?