anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #11152] fix(session): stop loop when model returns non-tool finish reason #13670

New Issue
Open
opened 2026-02-16 18:18:30 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:30 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/11152

State: open
Merged: No

Fixes #11153

When the model returns finish_reason=stop, the processor was returning "continue" causing repeated API calls with identical messages.

Change: Return "stop" from processor when finish reason is not "tool-calls" or "unknown".

Verification: Traced through logs from a stuck session - model returned finish_reason=stop but processor returned "continue", loop kept running. With this fix, processor returns "stop" and loop breaks.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/11152 **State:** open **Merged:** No --- Fixes #11153 When the model returns finish_reason=stop, the processor was returning "continue" causing repeated API calls with identical messages. **Change:** Return "stop" from processor when finish reason is not "tool-calls" or "unknown". **Verification:** Traced through logs from a stuck session - model returned finish_reason=stop but processor returned "continue", loop kept running. With this fix, processor returns "stop" and loop breaks.
yindo added the pull-request label 2026-02-16 18:18:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13670
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?