anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #11181] fix: convert JSON string tool outputs to objects for Bedrock compatibility #13680

New Issue
Closed
opened 2026-02-16 18:18:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:31 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/11181

State: closed
Merged: No

Summary

AWS Bedrock rejects tool results with string content, requiring JSON objects instead. This fix detects when a tool output is a valid JSON string (like the output from todowrite tool) and parses it into an object before sending to the model provider.

Problem

When tool results contain JSON strings (e.g., JSON.stringify(todos, null, 2)), AWS Bedrock returns the error:

"The format of the value at messages.X.content.0.toolResult.content.0.json is invalid. Provide a json object for the field and try again."

This is because Bedrock requires tool result content to be a JSON object, not a string containing JSON.

Solution

Modified the toModelOutput function in packages/opencode/src/session/message-v2.ts to:

  1. Attempt to parse string outputs as JSON
  2. If successful and the result is an object/array, return as { type: "json", value: parsed }
  3. Otherwise, fall back to { type: "text", value: output } for plain text

Changes

  • packages/opencode/src/session/message-v2.ts: Added JSON parsing logic to toModelOutput
  • packages/opencode/test/session/message-v2.test.ts: Added tests for JSON string and plain text tool outputs

Test Results

All 15 tests pass:

  • 13 existing tests continue to pass
  • 2 new tests verify JSON string → object conversion and plain text handling

Related

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/11181 **State:** closed **Merged:** No --- ## Summary AWS Bedrock rejects tool results with string content, requiring JSON objects instead. This fix detects when a tool output is a valid JSON string (like the output from `todowrite` tool) and parses it into an object before sending to the model provider. ## Problem When tool results contain JSON strings (e.g., `JSON.stringify(todos, null, 2)`), AWS Bedrock returns the error: ``` "The format of the value at messages.X.content.0.toolResult.content.0.json is invalid. Provide a json object for the field and try again." ``` This is because Bedrock requires tool result content to be a JSON object, not a string containing JSON. ## Solution Modified the `toModelOutput` function in `packages/opencode/src/session/message-v2.ts` to: 1. Attempt to parse string outputs as JSON 2. If successful and the result is an object/array, return as `{ type: "json", value: parsed }` 3. Otherwise, fall back to `{ type: "text", value: output }` for plain text ## Changes - `packages/opencode/src/session/message-v2.ts`: Added JSON parsing logic to `toModelOutput` - `packages/opencode/test/session/message-v2.test.ts`: Added tests for JSON string and plain text tool outputs ## Test Results All 15 tests pass: - 13 existing tests continue to pass - 2 new tests verify JSON string → object conversion and plain text handling ## Related - Fixes #11035 - Related to AWS SDK issue: https://github.com/aws/aws-sdk-js-v3/issues/7330 🤖 Generated with [Claude Code](https://claude.com/claude-code)
yindo added the pull-request label 2026-02-16 18:18:31 -05:00
yindo closed this issue 2026-02-16 18:18:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13680
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?