anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #11220] fix: address potential issues in transitions PR #13705

New Issue
Closed
opened 2026-02-16 18:18:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:32 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/11220

State: closed
Merged: Yes

What does this PR do?

Fixes three potential issues identified in code review of the transitions/scroll-fade changes:

  • Session ID access safety: Added optional chaining to session.id in shell and command handlers (prompt-input.tsx lines 1258, 1281) for consistency with the rest of the file
  • ScrollFade RAF optimization: Changed continuous 60fps polling to conditional polling that only runs when trackTransformSelector is active, stops after 1s of inactivity
  • Dialog state management: Removed duplicate renders state update in dialog.close() - cleanup now handled solely by the onClose callback

How did you verify your code works?

Code review by static analysis. Changes are defensive improvements to prevent potential runtime errors and performance issues.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/11220 **State:** closed **Merged:** Yes --- ### What does this PR do? Fixes three potential issues identified in code review of the transitions/scroll-fade changes: - **Session ID access safety**: Added optional chaining to `session.id` in shell and command handlers (prompt-input.tsx lines 1258, 1281) for consistency with the rest of the file - **ScrollFade RAF optimization**: Changed continuous 60fps polling to conditional polling that only runs when `trackTransformSelector` is active, stops after 1s of inactivity - **Dialog state management**: Removed duplicate `renders` state update in `dialog.close()` - cleanup now handled solely by the `onClose` callback ### How did you verify your code works? Code review by static analysis. Changes are defensive improvements to prevent potential runtime errors and performance issues. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/anomalyco/opencode/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
yindo added the pull-request label 2026-02-16 18:18:32 -05:00
yindo closed this issue 2026-02-16 18:18:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13705
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?