anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #11316] fix(opencode): fix issues with glob behaviour for config instructions… #13737

New Issue
Open
opened 2026-02-16 18:18:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/11316

State: open
Merged: No

… and changes to support testing global instructions

What does this PR do?

Changes to instuctions.ts to correct path loading behviour so the full range of glob patterns work.

Previously ** globs would get parse out by path.dirname (actually resulting in a file not found error which was silent).

I suspect this was probably related to #8892, and maybe some other issues around instructions being ignored.

Fixes #11317

How did you verify your code works?

Added tests to instructions.test.ts to cover cases for globs and global config instructions which seemed to not previously covered.

It's worth noting, whilst digging around the tests and code, getting the tests to ignore my actual homedir was very challenging do to the inconsistent use of Global.path.home, Global.path.config and os.homedir().

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/11316 **State:** open **Merged:** No --- … and changes to support testing global instructions ### What does this PR do? Changes to `instuctions.ts` to correct path loading behviour so the full range of glob patterns work. Previously `**` globs would get parse out by `path.dirname` (actually resulting in a file not found error which was silent). I suspect this was probably related to #8892, and maybe some other issues around instructions being ignored. Fixes #11317 ### How did you verify your code works? Added tests to `instructions.test.ts` to cover cases for globs and global config instructions which seemed to not previously covered. It's worth noting, whilst digging around the tests and code, getting the tests to ignore my actual homedir was very challenging do to the inconsistent use of `Global.path.home`, `Global.path.config` and `os.homedir()`.
yindo added the pull-request label 2026-02-16 18:18:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13737
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?