anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #11406] fix(console): handle nested tools and preserve strict in oa-compat #13777

New Issue
Open
opened 2026-02-16 18:18:36 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:36 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/11406

State: open
Merged: No

Fixes #11171

What does this PR do?

  • Ensures toOaCompatibleRequest supports tools arriving in either:
    • flat format: { name, description, parameters, strict? }
    • nested OpenAI format: { type: "function", function: { name, description, parameters, strict? } }
  • Preserves strict when building the OpenAI-compatible tool schema.

Why?

When tools arrive nested, the current mapping reads tool.name etc. as undefined, which results in empty tool definitions being sent to the model and breaks tool calling (observed with Qwen2.5).

How did you verify?

  • Confirmed the serialized request now includes correct tool fields (name/description/parameters) for nested tools.
  • Verified strict is included in the outgoing tool definition.
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/11406 **State:** open **Merged:** No --- Fixes #11171 ### What does this PR do? - Ensures `toOaCompatibleRequest` supports tools arriving in either: - flat format: `{ name, description, parameters, strict? }` - nested OpenAI format: `{ type: "function", function: { name, description, parameters, strict? } }` - Preserves `strict` when building the OpenAI-compatible tool schema. ### Why? When tools arrive nested, the current mapping reads `tool.name` etc. as `undefined`, which results in empty tool definitions being sent to the model and breaks tool calling (observed with Qwen2.5). ### How did you verify? - Confirmed the serialized request now includes correct tool fields (`name/description/parameters`) for nested tools. - Verified `strict` is included in the outgoing tool definition.
yindo added the pull-request label 2026-02-16 18:18:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#13777
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?