anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-23 02:36:57 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #12127] fix(lsp): handle Java versions without minor/patch numbers #14077

New Issue
Open
opened 2026-02-16 18:18:53 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:53 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/12127

State: open
Merged: No

What does this PR do?

Fixes Java version detection for JDTLS installation when java -version outputs only the major version.

Problem: The regex /"(\d+)\.\d+\.\d+"/ expects format like "21.0.0", but some distributions (e.g., Temurin-21+35) output just "21":

openjdk version "21" 2023-09-19 LTS

Fix: Changed regex to /"(\d+)(?:\.\d+)*"/ which matches both formats.

Fixes #12120

How did you verify your code works?

Tested the regex against multiple Java version string formats:

// All return the correct major version:
"21"     -> 21  ✓ (was failing before)
"21.0.0" -> 21  ✓
"21.0.5" -> 21  ✓
"17.0.2" -> 17  ✓
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/12127 **State:** open **Merged:** No --- ### What does this PR do? Fixes Java version detection for JDTLS installation when `java -version` outputs only the major version. **Problem:** The regex `/"(\d+)\.\d+\.\d+"/` expects format like `"21.0.0"`, but some distributions (e.g., Temurin-21+35) output just `"21"`: ``` openjdk version "21" 2023-09-19 LTS ``` **Fix:** Changed regex to `/"(\d+)(?:\.\d+)*"/` which matches both formats. Fixes #12120 ### How did you verify your code works? Tested the regex against multiple Java version string formats: ```javascript // All return the correct major version: "21" -> 21 ✓ (was failing before) "21.0.0" -> 21 ✓ "21.0.5" -> 21 ✓ "17.0.2" -> 17 ✓ ```
yindo added the pull-request label 2026-02-16 18:18:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14077
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?