anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #12270] fix: handle custom tool import failures gracefully in registry #14143

New Issue
Open
opened 2026-02-16 18:18:57 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:57 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/12270

State: open
Merged: No

Summary

Fixes #12269 — the tool registry now catches and logs errors when a custom tool fails to import (e.g. due to unresolvable dependencies) instead of crashing the entire registry initialization.

Changes

  • packages/opencode/src/tool/registry.ts — wrap import(match) in try/catch, log warning and skip tools that fail to load
  • packages/opencode/test/tool/registry.test.ts — fix the loads tools with external dependencies without crashing test to verify resilience (registry doesn't crash) rather than expecting the tool to be loaded when its dependencies can't be resolved

Context

Commit 556adad67 (#12227) added a test that creates a custom tool importing cowsay, but the dependency is never installed in the test's temp directory. This causes a deterministic failure on CI that blocks all PRs targeting dev:

error: Cannot find package 'cowsay' from '/tmp/opencode-test-xxx/.opencode/tools/cowsay.ts'
(fail) tool.registry > loads tools with external dependencies without crashing [269.71ms]

881 pass / 1 fail

The production code fix (try/catch) is also good defensive programming — if bun install fails for any reason (network error, disk full, etc.), the registry should still work for all other tools rather than crashing entirely.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/12270 **State:** open **Merged:** No --- ## Summary Fixes #12269 — the tool registry now catches and logs errors when a custom tool fails to import (e.g. due to unresolvable dependencies) instead of crashing the entire registry initialization. ## Changes - **`packages/opencode/src/tool/registry.ts`** — wrap `import(match)` in try/catch, log warning and skip tools that fail to load - **`packages/opencode/test/tool/registry.test.ts`** — fix the `loads tools with external dependencies without crashing` test to verify resilience (registry doesn't crash) rather than expecting the tool to be loaded when its dependencies can't be resolved ## Context Commit `556adad67` (#12227) added a test that creates a custom tool importing `cowsay`, but the dependency is never installed in the test's temp directory. This causes a deterministic failure on CI that blocks **all PRs** targeting `dev`: ``` error: Cannot find package 'cowsay' from '/tmp/opencode-test-xxx/.opencode/tools/cowsay.ts' (fail) tool.registry > loads tools with external dependencies without crashing [269.71ms] 881 pass / 1 fail ``` The production code fix (try/catch) is also good defensive programming — if `bun install` fails for any reason (network error, disk full, etc.), the registry should still work for all other tools rather than crashing entirely.
yindo added the pull-request label 2026-02-16 18:18:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14143
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?