anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #12354] fix: clean up orphaned store data on session deletion and message removal #14182

New Issue
Closed
opened 2026-02-16 18:18:59 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:18:59 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/12354

State: closed
Merged: No

Fixes #12351

The session.deleted handler in the TUI sync store only removes the session from store.session[] but leaves everything else behind — message, part, session_diff, todo, permission, question, session_status all stick around as orphaned entries. Over time this leaks memory with every deleted session.

The web app already handles this properly in cleanupSessionCaches() (packages/app/src/context/global-sync.tsx lines 676-706), the TUI just never got the same treatment.

Also fixed message.removed — it was removing the message from the array but not cleaning up its part entries.

Changes:

  • session.deleted: now cleans up all 7 keyed maps + removes from fullSyncedSessions
  • message.removed: now also deletes orphaned part[messageID]
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/12354 **State:** closed **Merged:** No --- Fixes #12351 The `session.deleted` handler in the TUI sync store only removes the session from `store.session[]` but leaves everything else behind — `message`, `part`, `session_diff`, `todo`, `permission`, `question`, `session_status` all stick around as orphaned entries. Over time this leaks memory with every deleted session. The web app already handles this properly in `cleanupSessionCaches()` (`packages/app/src/context/global-sync.tsx` lines 676-706), the TUI just never got the same treatment. Also fixed `message.removed` — it was removing the message from the array but not cleaning up its `part` entries. Changes: - `session.deleted`: now cleans up all 7 keyed maps + removes from `fullSyncedSessions` - `message.removed`: now also deletes orphaned `part[messageID]`
yindo added the pull-request label 2026-02-16 18:18:59 -05:00
yindo closed this issue 2026-02-16 18:18:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?