anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #12869] fix: OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS env var silently ignored #14410

New Issue
Closed
opened 2026-02-16 18:19:12 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:12 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/12869

State: closed
Merged: No

Summary

  • Fix regression where OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS environment variable is silently ignored
  • The flag was evaluated as a static const at module load time, so the env var value was captured once (as undefined) and never re-read
  • Convert the flag to a dynamic getter via Object.defineProperty (consistent with other dynamic flags like OPENCODE_CLIENT, OPENCODE_CONFIG_DIR)
  • Change DEFAULT_TIMEOUT in the bash tool from a module-level constant to a lazy function call so it reads the flag value at execution time

Test plan

  • Set OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS=5000 and verify bash commands time out after 5 seconds
  • Verify default timeout of 120000ms still applies when env var is not set
  • Verify invalid values (non-integer, negative, zero) are ignored and fallback to default

Fixes #12762

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/12869 **State:** closed **Merged:** No --- ## Summary - Fix regression where `OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS` environment variable is silently ignored - The flag was evaluated as a static `const` at module load time, so the env var value was captured once (as `undefined`) and never re-read - Convert the flag to a dynamic getter via `Object.defineProperty` (consistent with other dynamic flags like `OPENCODE_CLIENT`, `OPENCODE_CONFIG_DIR`) - Change `DEFAULT_TIMEOUT` in the bash tool from a module-level constant to a lazy function call so it reads the flag value at execution time ## Test plan - [ ] Set `OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS=5000` and verify bash commands time out after 5 seconds - [ ] Verify default timeout of 120000ms still applies when env var is not set - [ ] Verify invalid values (non-integer, negative, zero) are ignored and fallback to default Fixes #12762
yindo added the pull-request label 2026-02-16 18:19:12 -05:00
yindo closed this issue 2026-02-16 18:19:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?