anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #12870] fix: track session status for prompt_async and guard against missing agent #14411

New Issue
Closed
opened 2026-02-16 18:19:12 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:19:12 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/12870

State: closed
Merged: No

Summary

  • Set session status to busy immediately when prompt_async is called, so /session/status correctly reflects the active state instead of remaining unknown
  • Add .catch() handler on the fire-and-forget prompt promise to reset status to idle on failure and log the error, preventing the status from getting permanently stuck
  • Add a null check for the agent returned by Agent.get() in createUserMessage to prevent TypeError: undefined is not an object (evaluating 'agent.model') when an invalid agent name is provided

Test plan

  • Call POST /:sessionID/prompt_async and verify /session/status returns busy immediately
  • Verify status transitions to idle after the prompt completes
  • Trigger an error during async prompt (e.g. invalid agent) and verify status resets to idle
  • Send a prompt with a non-existent agent name and verify a clear error message instead of a TypeError

Fixes #12860

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/12870 **State:** closed **Merged:** No --- ## Summary - Set session status to `busy` immediately when `prompt_async` is called, so `/session/status` correctly reflects the active state instead of remaining `unknown` - Add `.catch()` handler on the fire-and-forget prompt promise to reset status to `idle` on failure and log the error, preventing the status from getting permanently stuck - Add a null check for the agent returned by `Agent.get()` in `createUserMessage` to prevent `TypeError: undefined is not an object (evaluating 'agent.model')` when an invalid agent name is provided ## Test plan - [ ] Call `POST /:sessionID/prompt_async` and verify `/session/status` returns `busy` immediately - [ ] Verify status transitions to `idle` after the prompt completes - [ ] Trigger an error during async prompt (e.g. invalid agent) and verify status resets to `idle` - [ ] Send a prompt with a non-existent agent name and verify a clear error message instead of a TypeError Fixes #12860
yindo added the pull-request label 2026-02-16 18:19:12 -05:00
yindo closed this issue 2026-02-16 18:19:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#14411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?